# HG changeset patch # User gthomas # Date 1067954793 0 # Node ID 4444f5b3be7b0ebb0511aaa6242c322e11710677 # Parent 0786f4fb3f8c2d6d558686d76009963c2bf8ff2f Fix 'fis free' list handling - from Chris Garry diff --git a/packages/redboot/current/ChangeLog b/packages/redboot/current/ChangeLog --- a/packages/redboot/current/ChangeLog +++ b/packages/redboot/current/ChangeLog @@ -1,3 +1,8 @@ +2003-11-04 Gary Thomas + + * src/flash.c (find_free): Better handling of end address - otherwise + list of free blocks could be incorrect. Thanks to Chris Garry. + 2003-11-01 Gary Thomas * cdl/redboot.cdl: Reorg to allow disk operations on other than diff --git a/packages/redboot/current/src/flash.c b/packages/redboot/current/src/flash.c --- a/packages/redboot/current/src/flash.c +++ b/packages/redboot/current/src/flash.c @@ -523,9 +523,9 @@ find_free(struct free_chunk *chunks) // Do not search the area reserved for pre-RedBoot systems: fis_ptr = (CYG_ADDRESS *)((CYG_ADDRESS)flash_start + - CYGNUM_REDBOOT_FLASH_RESERVED_BASE + - CYGBLD_REDBOOT_MIN_IMAGE_SIZE); - fis_end = (CYG_ADDRESS *)(CYG_ADDRESS)flash_end; + CYGNUM_REDBOOT_FLASH_RESERVED_BASE + + CYGBLD_REDBOOT_MIN_IMAGE_SIZE); + fis_end = (CYG_ADDRESS *)flash_end; chunks[num_chunks-1].start = (CYG_ADDRESS)fis_ptr; chunks[num_chunks-1].end = (CYG_ADDRESS)fis_end; flash_read(fis_addr, fis_work_block, fisdir_size, (void **)&err_addr); @@ -538,7 +538,7 @@ find_free(struct free_chunk *chunks) (img->flash_base <= chunks[idx].end)) { if (img->flash_base == chunks[idx].start) { chunks[idx].start += img->size; - if (chunks[idx].start == chunks[idx].end) { + if (chunks[idx].start >= chunks[idx].end) { // This free chunk has collapsed while (idx < (num_chunks-1)) { chunks[idx] = chunks[idx+1];